[output] PagerDuty incident requires "From:" header #493
Conversation
| @@ -291,21 +296,23 @@ def _check_exists_get_id(self, filter_str, url, target_key): | |||
| return False | |||
|
|
|||
| # If there are results, get the first occurence from the list | |||
| return response[target_key][0]['id'] if target_key in response else False | |||
| if get_id: | |||
There was a problem hiding this comment.
do the inverse please
if not get_id:
return True
# If there are results, get the first occurance from the list
return response[target_key][0]['id'] if target_key in response else False
There was a problem hiding this comment.
hey @javuto good job catching this. some initial comments for ya
| """ | ||
| item_id = self._check_exists_get_id(item_str, item_url, item_key) | ||
| item_url = self._get_endpoint(self._base_url, item_key) |
There was a problem hiding this comment.
good change, putting this in one place!
| 'type': item_type | ||
| } | ||
| if get_id: | ||
| return { |
There was a problem hiding this comment.
put this dict on one line:
return {id': item_id, 'type': item_type}
| return self._log_status(False) | ||
|
|
||
| # Add From to the headers after verifying | ||
| self._headers['From'] = user_email |
There was a problem hiding this comment.
is this header value really title case (From)?
There was a problem hiding this comment.
|
|
||
| def _user_verify(self, user): | ||
| def _user_verify(self, user, get_id=True): |
There was a problem hiding this comment.
It looks like the only time this function is called, the default value for get_id is overridden with False... am I missing something? When would get_id ever be True here?
There was a problem hiding this comment.
In _incident_assignment it gets called and the default True value is used
javuto
force-pushed
the
javier-streamalert-pagerduty-incidents-bugs
branch
from
873d748 to
1001bab
Compare
javuto
force-pushed
the
javier-streamalert-pagerduty-incidents-bugs
branch
from
0043af9 to
6406c94
Compare
|
Changes Unknown when pulling 6406c94 on javier-streamalert-pagerduty-incidents-bugs into ** on master**. |
to: @ryandeivert @jacknagz
cc: @airbnb/streamalert-maintainers
size: small
Background
New output to use PagerDuty Incidents was added here. The REST API requires the header
From: validpagerdutyuser@email.comto create a new incident.Changes
From:is added to authentication, and the user will be added when creating new output._check_existsto optionally return just a boolean.Testing